diff options
| author | Sebastiano Tronto <sebastiano@tronto.net> | 2025-05-27 09:03:51 +0200 |
|---|---|---|
| committer | Sebastiano Tronto <sebastiano@tronto.net> | 2025-05-27 09:03:51 +0200 |
| commit | 7c934801f88c640970ad41b5ddd39f4e39609f28 (patch) | |
| tree | 76a065db76fbcbdec818b8b6cc8b108ac1c9eb49 /src/solvers/h48 | |
| parent | 243a852d31483d10983c50978d1d4471efd0e553 (diff) | |
| download | nissy-core-7c934801f88c640970ad41b5ddd39f4e39609f28.tar.gz nissy-core-7c934801f88c640970ad41b5ddd39f4e39609f28.zip | |
Removed VLA notation from function parameters.
I found out that this gives undefined behavior when then size is 0.
Better not to have it at all, it is confusing for other developers anyway.
Diffstat (limited to 'src/solvers/h48')
| -rw-r--r-- | src/solvers/h48/checkdata.h | 4 | ||||
| -rw-r--r-- | src/solvers/h48/solve.h | 12 |
2 files changed, 8 insertions, 8 deletions
diff --git a/src/solvers/h48/checkdata.h b/src/solvers/h48/checkdata.h index 53e616b..d36d8cc 100644 --- a/src/solvers/h48/checkdata.h +++ b/src/solvers/h48/checkdata.h | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | STATIC long long checkdata_h48( | 1 | STATIC long long checkdata_h48( |
| 2 | const char *, unsigned long long n, const unsigned char [n]); | 2 | const char *, unsigned long long, const unsigned char *); |
| 3 | 3 | ||
| 4 | /* | 4 | /* |
| 5 | Currently unused. | 5 | Currently unused. |
| @@ -178,7 +178,7 @@ STATIC long long | |||
| 178 | checkdata_h48( | 178 | checkdata_h48( |
| 179 | const char *solver, | 179 | const char *solver, |
| 180 | unsigned long long data_size, | 180 | unsigned long long data_size, |
| 181 | const unsigned char data[data_size] | 181 | const unsigned char *data |
| 182 | ) | 182 | ) |
| 183 | { | 183 | { |
| 184 | const unsigned char *table; | 184 | const unsigned char *table; |
diff --git a/src/solvers/h48/solve.h b/src/solvers/h48/solve.h index 7e2e5c1..bf34a2b 100644 --- a/src/solvers/h48/solve.h +++ b/src/solvers/h48/solve.h | |||
| @@ -49,8 +49,8 @@ typedef struct { | |||
| 49 | } dfsarg_solve_h48_maketasks_t; | 49 | } dfsarg_solve_h48_maketasks_t; |
| 50 | 50 | ||
| 51 | STATIC long long solve_h48_dispatch(oriented_cube_t, const char *, unsigned, | 51 | STATIC long long solve_h48_dispatch(oriented_cube_t, const char *, unsigned, |
| 52 | unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long n, | 52 | unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long, |
| 53 | const unsigned char [n], unsigned m, char [m], | 53 | const unsigned char *, unsigned, char *, |
| 54 | long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *); | 54 | long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *); |
| 55 | STATIC_INLINE bool solve_h48_stop(dfsarg_solve_h48_t [static 1]); | 55 | STATIC_INLINE bool solve_h48_stop(dfsarg_solve_h48_t [static 1]); |
| 56 | STATIC int64_t solve_h48_maketasks( | 56 | STATIC int64_t solve_h48_maketasks( |
| @@ -60,7 +60,7 @@ STATIC void *solve_h48_runthread(void *); | |||
| 60 | STATIC int64_t solve_h48_dfs(dfsarg_solve_h48_t [static 1]); | 60 | STATIC int64_t solve_h48_dfs(dfsarg_solve_h48_t [static 1]); |
| 61 | STATIC void solve_h48_log_solutions(solution_list_t [static 1], size_t); | 61 | STATIC void solve_h48_log_solutions(solution_list_t [static 1], size_t); |
| 62 | STATIC int64_t solve_h48(oriented_cube_t, uint8_t, uint8_t, uint8_t, uint8_t, | 62 | STATIC int64_t solve_h48(oriented_cube_t, uint8_t, uint8_t, uint8_t, uint8_t, |
| 63 | uint8_t, uint64_t, const unsigned char *, size_t n, char [n], | 63 | uint8_t, uint64_t, const unsigned char *, size_t, char *, |
| 64 | long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *); | 64 | long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *); |
| 65 | 65 | ||
| 66 | STATIC long long solve_h48_dispatch( | 66 | STATIC long long solve_h48_dispatch( |
| @@ -73,9 +73,9 @@ STATIC long long solve_h48_dispatch( | |||
| 73 | unsigned optimal, | 73 | unsigned optimal, |
| 74 | unsigned threads, | 74 | unsigned threads, |
| 75 | unsigned long long data_size, | 75 | unsigned long long data_size, |
| 76 | const unsigned char data[data_size], | 76 | const unsigned char *data, |
| 77 | unsigned sols_size, | 77 | unsigned sols_size, |
| 78 | char sols[sols_size], | 78 | char *sols, |
| 79 | long long stats[static NISSY_SIZE_SOLVE_STATS], | 79 | long long stats[static NISSY_SIZE_SOLVE_STATS], |
| 80 | int (*poll_status)(void *), | 80 | int (*poll_status)(void *), |
| 81 | void *poll_status_data | 81 | void *poll_status_data |
| @@ -410,7 +410,7 @@ solve_h48( | |||
| 410 | uint64_t data_size, | 410 | uint64_t data_size, |
| 411 | const unsigned char *data, | 411 | const unsigned char *data, |
| 412 | size_t solutions_size, | 412 | size_t solutions_size, |
| 413 | char solutions[solutions_size], | 413 | char *solutions, |
| 414 | long long stats[static NISSY_SIZE_SOLVE_STATS], | 414 | long long stats[static NISSY_SIZE_SOLVE_STATS], |
| 415 | int (*poll_status)(void *), | 415 | int (*poll_status)(void *), |
| 416 | void *poll_status_data | 416 | void *poll_status_data |
