From 7c934801f88c640970ad41b5ddd39f4e39609f28 Mon Sep 17 00:00:00 2001 From: Sebastiano Tronto Date: Tue, 27 May 2025 09:03:51 +0200 Subject: Removed VLA notation from function parameters. I found out that this gives undefined behavior when then size is 0. Better not to have it at all, it is confusing for other developers anyway. --- src/solvers/h48/checkdata.h | 4 ++-- src/solvers/h48/solve.h | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/solvers/h48') diff --git a/src/solvers/h48/checkdata.h b/src/solvers/h48/checkdata.h index 53e616b..d36d8cc 100644 --- a/src/solvers/h48/checkdata.h +++ b/src/solvers/h48/checkdata.h @@ -1,5 +1,5 @@ STATIC long long checkdata_h48( - const char *, unsigned long long n, const unsigned char [n]); + const char *, unsigned long long, const unsigned char *); /* Currently unused. @@ -178,7 +178,7 @@ STATIC long long checkdata_h48( const char *solver, unsigned long long data_size, - const unsigned char data[data_size] + const unsigned char *data ) { const unsigned char *table; diff --git a/src/solvers/h48/solve.h b/src/solvers/h48/solve.h index 7e2e5c1..bf34a2b 100644 --- a/src/solvers/h48/solve.h +++ b/src/solvers/h48/solve.h @@ -49,8 +49,8 @@ typedef struct { } dfsarg_solve_h48_maketasks_t; STATIC long long solve_h48_dispatch(oriented_cube_t, const char *, unsigned, - unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long n, - const unsigned char [n], unsigned m, char [m], + unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long, + const unsigned char *, unsigned, char *, long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *); STATIC_INLINE bool solve_h48_stop(dfsarg_solve_h48_t [static 1]); STATIC int64_t solve_h48_maketasks( @@ -60,7 +60,7 @@ STATIC void *solve_h48_runthread(void *); STATIC int64_t solve_h48_dfs(dfsarg_solve_h48_t [static 1]); STATIC void solve_h48_log_solutions(solution_list_t [static 1], size_t); STATIC int64_t solve_h48(oriented_cube_t, uint8_t, uint8_t, uint8_t, uint8_t, - uint8_t, uint64_t, const unsigned char *, size_t n, char [n], + uint8_t, uint64_t, const unsigned char *, size_t, char *, long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *); STATIC long long solve_h48_dispatch( @@ -73,9 +73,9 @@ STATIC long long solve_h48_dispatch( unsigned optimal, unsigned threads, unsigned long long data_size, - const unsigned char data[data_size], + const unsigned char *data, unsigned sols_size, - char sols[sols_size], + char *sols, long long stats[static NISSY_SIZE_SOLVE_STATS], int (*poll_status)(void *), void *poll_status_data @@ -410,7 +410,7 @@ solve_h48( uint64_t data_size, const unsigned char *data, size_t solutions_size, - char solutions[solutions_size], + char *solutions, long long stats[static NISSY_SIZE_SOLVE_STATS], int (*poll_status)(void *), void *poll_status_data -- cgit v1.3