nissy-core

commit af6e9af26e0f547b41fc85f1cce07040cb3dbc87
parent bcd52547af58b15868e24f3904e307548d1fd505
Author: Sebastiano Tronto <sebastiano@tronto.net>
Date:   Sun, 14 Dec 2025 19:35:57 +0100

Update comments

Diffstat:
M
src/solvers/h48/checkdata.h
 | 
5
++++-
M
src/solvers/h48/gendata_h48.h
 | 
7
+++----

2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/solvers/h48/checkdata.h b/src/solvers/h48/checkdata.h
@@ -1,7 +1,6 @@
 STATIC long long checkdata_h48(
     const char *, unsigned long long, const unsigned char *);
 
-/* TODO: Currently unused, re-introduce check on cocsep table */
 uint64_t expected_cocsep[21] = {
 	[0] = 1,
 	[1] = 6,
@@ -130,6 +129,10 @@ struct {
 };
 
 /*
+TODO: add check for cocsep table.
+
+TODO: add check for fallback values at the end of each line.
+
 TODO: this function can be simplified, now we support only one h48 table +
 eoesep. The loop can be just two checks.
 */
diff --git a/src/solvers/h48/gendata_h48.h b/src/solvers/h48/gendata_h48.h
@@ -172,10 +172,9 @@ gendata_h48_maintable(gendata_h48_arg_t arg[static 1])
 	 *   [2] = 462294676
 	 *   [3] = 14900555
 	 *
-	 * I ended up picking base 8 to have a much lower count of elements
-	 * with value 0, at the cost of a less precise estimate for the higher
-	 * values. But I am not 100% confident this is the optimal choice,
-	 * so I'll leave it here for future considerations.
+	 * Experimentally, the table with base 8 is much faster. Intuitively,
+	 * this is because it has a much lower count of elements  with value 0,
+         * at the cost of a less precise estimate for the higher values.
 	 */
 	 
 	static const uint8_t base[] = {