Various shellcheck fixes (www.shellcheck.net)

1 files changed, 13 insertions, 3 deletions

diff --git a/dmenu-dwm-sessionmanager b/dmenu-dwm-sessionmanager
index f423a09..dafe853 100755
--- a/dmenu-dwm-sessionmanager
+++ b/dmenu-dwm-sessionmanager
@@ -1,26 +1,36 @@
 #!/bin/sh
 
 # Prompts menu to shutdown/reboot/close dwm
-# Usage: dmenu-dwm-sessionmanager [-m menu]
 # Requires: dmenu (or equivalent), dwm (optional)
 
+# Usage: dmenu-dwm-sessionmanager [-m menu]
+
 menu="dmenu -i"
 prompt="Do you want to quit?"
+
+usage() {
+        echo "Usage: dmenu-dwm-sessionmanager [-m MENU]"
+}
+
 while getopts "m:" opt; do
         case "$opt" in
                 m)
                         menu="$OPTARG"
                         ;;
+                *)
+                        usage
+                        exit 1
+                        ;;
         esac
 done
-shift `expr $OPTIND - 1`
+shift $((OPTIND - 1))
 
 wmname="dwm"
 shutdown_cmd="sudo shutdown -h now"
 reboot_cmd="sudo reboot"
 closewm_cmd="pkill $wmname"
 
-value=$(echo "Shutdown\nReboot\nQuit dwm" | $menu -p "$prompt")
+value=$(printf 'Shutdown\nReboot\nQuit dwm\n' | $menu -p "$prompt")
 
 if [ "$value" = "Shutdown" ]; then
         $shutdown_cmd