4 files changed, 79 insertions, 111 deletions

diff --git a/src/core/cube.h b/src/core/cube.h
index 4b28103..df5161a 100644
--- a/src/core/cube.h
+++ b/src/core/cube.h
@@ -1,25 +1,12 @@
-#define _move(M, c) compose(c, _move_cube_ ## M)
-#define _premove(M, c) compose(_move_cube_ ## M, c)
-
 _static cube_t cubefromarray(uint8_t [static 8], uint8_t [static 12]);
 _static cube_t solvedcube(void);
 _static bool isconsistent(cube_t);
 _static bool issolvable(cube_t);
 _static bool issolved(cube_t);
 _static bool iserror(cube_t);
-_static cube_t applymoves(cube_t, const char *);
-_static cube_t applytrans(cube_t, const char *);
-_static cube_t frommoves(const char *);
 _static void getcube_fix(int64_t *, int64_t *, int64_t *, int64_t *);
 _static cube_t getcube(int64_t, int64_t, int64_t, int64_t);
 
-_static cube_t transform_edges(cube_t, uint8_t);
-_static cube_t transform_corners(cube_t, uint8_t);
-_static cube_t transform(cube_t, uint8_t);
-
-/* declared in moves.h */
-_static cube_t move(cube_t, uint8_t);
-
 _static cube_t
 cubefromarray(uint8_t c[static 8], uint8_t e[static 12])
 {
@@ -149,41 +136,6 @@ iserror(cube_t cube)
         return equal(cube, zero);
 }
 
-_static cube_t
-applymoves(cube_t cube, const char *buf)
-{
-        uint8_t r, m;
-        const char *b;
-
-        DBG_ASSERT(isconsistent(cube), zero,
-            "move error: inconsistent cube\n");
-
-        for (b = buf; *b != '\0'; b++) {
-                while (*b == ' ' || *b == '\t' || *b == '\n')
-                        b++;
-                if (*b == '\0')
-                        goto applymoves_finish;
-                if ((r = readmove(*b)) == _error)
-                        goto applymoves_error;
-                if ((m = readmodifier(*(b+1))) != 0)
-                        b++;
-                cube = move(cube, r + m);
-        }
-
-applymoves_finish:
-        return cube;
-
-applymoves_error:
-        LOG("applymoves error\n");
-        return zero;
-}
-
-_static cube_t
-frommoves(const char *buf)
-{
-        return applymoves(solved, buf);
-}
-
 _static void
 getcube_fix(int64_t *ep, int64_t *eo, int64_t *cp, int64_t *co)
 {
@@ -227,21 +179,3 @@ getcube(int64_t ep, int64_t eo, int64_t cp, int64_t co)
 
         return cubefromarray(carr, earr);
 }
-
-_static cube_t
-applytrans(cube_t cube, const char *buf)
-{
-        uint8_t t;
-
-        DBG_ASSERT(isconsistent(cube), zero,
-            "transformation error: inconsistent cube\n");
-
-        t = readtrans(buf);
-
-        return transform(cube, t);
-}
-
-/*
-TODO transform is now relegated to a separated file because it is too long.
-It would be nice to make it shorter without loosing performance.
-*/
diff --git a/src/core/moves.h b/src/core/moves.h
index 8f9c8f5..71ef470 100644
--- a/src/core/moves.h
+++ b/src/core/moves.h
@@ -1,13 +1,7 @@
-/* probably these can be placed in constants file */
-#define NORMAL 0x00
-#define INVERSE 0x01
-#define INVERSEBRANCH 0x03
-#define NORMALBRANCH 0x02
-#define ALLMOVES 0x3FFFF
-#define NOHALFTURNS 0x2DB6D
+#define _move(M, c) compose(c, _move_cube_ ## M)
+#define _premove(M, c) compose(_move_cube_ ## M, c)
 
 _static_inline bool allowednextmove(uint8_t *, uint8_t);
-_static uint32_t allowednextmoveH48(uint8_t *, uint8_t, uint32_t);
 
 _static_inline uint8_t inverse_trans(uint8_t);
 _static_inline uint8_t movebase(uint8_t);
@@ -17,7 +11,10 @@ _static_inline uint32_t disable_moves(uint32_t, uint8_t);
 _static cube_t move(cube_t, uint8_t);
 _static cube_t premove(cube_t, uint8_t);
 _static uint8_t inverse_move(uint8_t);
-_static uint8_t* invertpremoves(uint8_t *, uint8_t);
+_static void invertmoves(uint8_t *, uint8_t, uint8_t *);
+
+_static cube_t applymoves(cube_t, const char *);
+_static cube_t frommoves(const char *);
 
 _static bool
 allowednextmove(uint8_t *moves, uint8_t n)
@@ -50,34 +47,6 @@ disable_moves(uint32_t current_result, uint8_t base_index)
         return current_result & ~(7 << base_index);
 }
 
-_static uint32_t
-allowednextmoveH48(uint8_t *moves, uint8_t n, uint32_t h48branch)
-{
-        uint32_t result = ALLMOVES;
-        if (h48branch & NORMALBRANCH)
-                result &= NOHALFTURNS;
-        if (n < 1)
-                return result;
-
-        uint8_t base1 = movebase(moves[n-1]);
-        uint8_t axis1 = moveaxis(moves[n-1]);
-
-        result = disable_moves(result, base1 * 3);
-        if (base1 % 2)
-                result = disable_moves(result, (base1 - 1) * 3);
-
-        if (n == 1)
-                return result;
-        
-        uint8_t base2 = movebase(moves[n-2]);
-        uint8_t axis2 = moveaxis(moves[n-2]);
-
-        if(axis1 == axis2)
-                result = disable_moves(result, base2 * 3);
-
-        return result;
-}
-
 _static_inline uint8_t
 inverse_trans(uint8_t t)
 {
@@ -194,17 +163,46 @@ inverse_move(uint8_t m)
         return m - 2 * (m % 3) + 2;     
 }
 
-_static uint8_t*
-invertpremoves(uint8_t *moves, uint8_t nmoves)
+_static void
+invertmoves(uint8_t *moves, uint8_t nmoves, uint8_t *ret)
 {
         uint8_t i;
-        uint8_t *ret = malloc(nmoves * sizeof(uint8_t));
 
         for (i = 0; i < nmoves; i++)
-                ret[i] = inverse_move(moves[i]);
+                ret[i] = inverse_move(moves[nmoves - i - 1]);
+}
 
-        // invert elements in the array
-        for (i = 0; i < nmoves / 2; i++)
-                _swap(ret[i], ret[nmoves - i - 1]);
-        return ret;
+_static cube_t
+applymoves(cube_t cube, const char *buf)
+{
+        uint8_t r, m;
+        const char *b;
+
+        DBG_ASSERT(isconsistent(cube), zero,
+            "move error: inconsistent cube\n");
+
+        for (b = buf; *b != '\0'; b++) {
+                while (*b == ' ' || *b == '\t' || *b == '\n')
+                        b++;
+                if (*b == '\0')
+                        goto applymoves_finish;
+                if ((r = readmove(*b)) == _error)
+                        goto applymoves_error;
+                if ((m = readmodifier(*(b+1))) != 0)
+                        b++;
+                cube = move(cube, r + m);
+        }
+
+applymoves_finish:
+        return cube;
+
+applymoves_error:
+        LOG("applymoves error\n");
+        return zero;
+}
+
+_static cube_t
+frommoves(const char *buf)
+{
+        return applymoves(solved, buf);
 }
diff --git a/src/core/transform.h b/src/core/transform.h
index 358b051..fa7ce59 100644
--- a/src/core/transform.h
+++ b/src/core/transform.h
@@ -19,6 +19,11 @@
         invertco(compose(compose(_trans_cube_ ## T, c), \
         _trans_cube_ ## T ## _inverse))
 
+_static cube_t transform_edges(cube_t, uint8_t);
+_static cube_t transform_corners(cube_t, uint8_t);
+_static cube_t transform(cube_t, uint8_t);
+_static cube_t applytrans(cube_t, const char *);
+
 static cube_t cube_trans_table[48] = {
         [_trans_UFr] = _trans_cube_UFr,
         [_trans_UFm] = _trans_cube_UFm,
@@ -174,3 +179,16 @@ transform(cube_t c, uint8_t t)
 
         return t < 24 ? ret : invertco(ret);
 }
+
+_static cube_t
+applytrans(cube_t cube, const char *buf)
+{
+        uint8_t t;
+
+        DBG_ASSERT(isconsistent(cube), zero,
+            "transformation error: inconsistent cube\n");
+
+        t = readtrans(buf);
+
+        return transform(cube, t);
+}
diff --git a/src/core/transform_with_switch.h b/src/core/transform_with_switch.h
index d3a108c..429e656 100644
--- a/src/core/transform_with_switch.h
+++ b/src/core/transform_with_switch.h
@@ -17,6 +17,11 @@
         invertco(compose(compose(_trans_cube_ ## T, c), \
         _trans_cube_ ## T ## _inverse))
 
+_static cube_t transform_edges(cube_t, uint8_t);
+_static cube_t transform_corners(cube_t, uint8_t);
+_static cube_t transform(cube_t, uint8_t);
+_static cube_t applytrans(cube_t, const char *);
+
 _static cube_t
 transform_edges(cube_t c, uint8_t t)
 {
@@ -334,3 +339,16 @@ transform(cube_t c, uint8_t t)
                 return zero;
         }
 }
+
+_static cube_t
+applytrans(cube_t cube, const char *buf)
+{
+        uint8_t t;
+
+        DBG_ASSERT(isconsistent(cube), zero,
+            "transformation error: inconsistent cube\n");
+
+        t = readtrans(buf);
+
+        return transform(cube, t);
+}