Make the project build with Microsoft's broken C compiler.

MSVC is not fully C11-compliant, even when compiling with /std:c11.
Some changes were needed to make the codebase compatible. Notably, the
notation a[static N] and a[n] for function parameters of array type is
not supported, so that had to be hidden behind a macro.  Atomic types
are also an experimental feature, apparently, but at least they work
with the correct compiler flag.

One thing that MSVC does well, however, is warning on integer conversions
on /W4 level. I am not sure if Clang and GCC have something similar,
so I took this chance to fix some of these.

1 files changed, 14 insertions, 14 deletions

diff --git a/src/solvers/h48/map.h b/src/solvers/h48/map.h
index b603ee3..c9cfb06 100644
--- a/src/solvers/h48/map.h
+++ b/src/solvers/h48/map.h
@@ -1,13 +1,13 @@
-STATIC void h48map_create(h48map_t [static 1], uint64_t, uint64_t);
-STATIC void h48map_clear(h48map_t [static 1]);
-STATIC void h48map_destroy(h48map_t [static 1]);
-STATIC uint64_t h48map_lookup(h48map_t [static 1], uint64_t);
-STATIC void h48map_insertmin(h48map_t [static 1], uint64_t, uint64_t);
-STATIC uint64_t h48map_value(h48map_t [static 1], uint64_t);
-STATIC kvpair_t h48map_nextkvpair(h48map_t [static 1], uint64_t [static 1]);
+STATIC void h48map_create(h48map_t [NON_NULL], uint64_t, uint64_t);
+STATIC void h48map_clear(h48map_t [NON_NULL]);
+STATIC void h48map_destroy(h48map_t [NON_NULL]);
+STATIC uint64_t h48map_lookup(h48map_t [NON_NULL], uint64_t);
+STATIC void h48map_insertmin(h48map_t [NON_NULL], uint64_t, uint64_t);
+STATIC uint64_t h48map_value(h48map_t [NON_NULL], uint64_t);
+STATIC kvpair_t h48map_nextkvpair(h48map_t [NON_NULL], uint64_t [NON_NULL]);
 
 STATIC void
-h48map_create(h48map_t map[static 1], uint64_t capacity, uint64_t randomizer)
+h48map_create(h48map_t map[NON_NULL], uint64_t capacity, uint64_t randomizer)
 {
         map->capacity = capacity;
         map->randomizer = randomizer;
@@ -17,20 +17,20 @@ h48map_create(h48map_t map[static 1], uint64_t capacity, uint64_t randomizer)
 }
 
 STATIC void
-h48map_clear(h48map_t map[static 1])
+h48map_clear(h48map_t map[NON_NULL])
 {
         memset(map->table, 0xFF, map->capacity * sizeof(uint64_t));
         map->n = 0;
 }
 
 STATIC void
-h48map_destroy(h48map_t map[static 1])
+h48map_destroy(h48map_t map[NON_NULL])
 {
         free(map->table);
 }
 
 STATIC_INLINE uint64_t
-h48map_lookup(h48map_t map[static 1], uint64_t x)
+h48map_lookup(h48map_t map[NON_NULL], uint64_t x)
 {
         uint64_t hash, i;
 
@@ -44,7 +44,7 @@ h48map_lookup(h48map_t map[static 1], uint64_t x)
 }
 
 STATIC_INLINE void
-h48map_insertmin(h48map_t map[static 1], uint64_t key, uint64_t val)
+h48map_insertmin(h48map_t map[NON_NULL], uint64_t key, uint64_t val)
 {
         uint64_t i, oldval, min;
 
@@ -57,13 +57,13 @@ h48map_insertmin(h48map_t map[static 1], uint64_t key, uint64_t val)
 }
 
 STATIC_INLINE uint64_t
-h48map_value(h48map_t map[static 1], uint64_t key)
+h48map_value(h48map_t map[NON_NULL], uint64_t key)
 {
         return map->table[h48map_lookup(map, key)] >> MAP_KEYSHIFT;
 }
 
 STATIC kvpair_t
-h48map_nextkvpair(h48map_t map[static 1], uint64_t p[static 1])
+h48map_nextkvpair(h48map_t map[NON_NULL], uint64_t p[NON_NULL])
 {
         kvpair_t kv;
         uint64_t pair;