4 files changed, 32 insertions, 26 deletions

diff --git a/src/solvers/h48/gendata_cocsep.h b/src/solvers/h48/gendata_cocsep.h
index 0f96da9..b7d28e1 100644
--- a/src/solvers/h48/gendata_cocsep.h
+++ b/src/solvers/h48/gendata_cocsep.h
@@ -135,7 +135,7 @@ gendata_cocsep_dfs(cocsep_dfs_arg_t *arg)
                 return cc;
         }
 
-        memcpy(&nextarg, arg, sizeof(cocsep_dfs_arg_t));
+        nextarg = *arg;
         nextarg.depth++;
         for (m = 0, cc = 0; m < 18; m++) {
                 nextarg.cube = move(arg->cube, m);
diff --git a/src/solvers/h48/gendata_h48.h b/src/solvers/h48/gendata_h48.h
index 2d222c9..6486834 100644
--- a/src/solvers/h48/gendata_h48.h
+++ b/src/solvers/h48/gendata_h48.h
@@ -1,6 +1,7 @@
 #define H48_COORDMAX_NOEO    ((int64_t)(COCSEP_CLASSES * _12c4 * _8c4))
 #define H48_COORDMAX(h)      ((int64_t)(H48_COORDMAX_NOEO << (int64_t)(h)))
-#define H48_TABLESIZE(h, k)  ((size_t)H48_COORDMAX((h)) / ((size_t)8 / (size_t)(k)))
+#define H48_DIV(k)           ((size_t)8 / (size_t)(k))
+#define H48_TABLESIZE(h, k)  _div_round_up((size_t)H48_COORDMAX((h)), H48_DIV(k))
 
 #define H48_COEFF(k)         (UINT32_C(32) / (uint32_t)(k))
 #define H48_INDEX(i, k)      ((uint32_t)(i) / H48_COEFF(k))
@@ -59,7 +60,7 @@ typedef struct {
 
 typedef struct {
         cube_t cube;
-        uint8_t moves[4];
+        uint8_t moves[MAXLEN];
         uint8_t h;
         uint8_t k;
         uint8_t base;
@@ -140,7 +141,7 @@ gendata_h48(gendata_h48_arg_t *arg)
         cocsepsize = gendata_cocsep(
             (void *)arg->cocsepdata, arg->selfsim, arg->crep);
         arg->h48data = arg->cocsepdata + (cocsepsize / sizeof(uint32_t));
-        arg->info = arg->h48data +
+        arg->info = arg->h48data + 1 +
             (H48_TABLESIZE(arg->h, arg->k) / sizeof(uint32_t));
 
         if (arg->buf != NULL)
@@ -303,14 +304,12 @@ gendata_h48k2(gendata_h48_arg_t *arg)
 
         uint8_t t;
         int64_t j;
-        uint64_t nshort, i;
+        uint64_t nshort, i, ii;
         h48map_t shortcubes;
         kvpair_t kv;
         gendata_h48short_arg_t shortarg;
         h48k2_dfs_arg_t dfsarg;
 
-        DBG_ASSERT(base[arg->h] == 8, 0, "Only implemented for h <= 3 (base 8)\n");
-
         if (arg->buf == NULL)
                 goto gendata_h48k2_return_size;
 
@@ -332,7 +331,7 @@ gendata_h48k2(gendata_h48_arg_t *arg)
                 .base = base[arg->h],
                 .depth = shortdepth,
                 .shortdepth = shortdepth,
-                .maxdepth = arg->maxdepth,
+                .maxdepth = _min(arg->maxdepth, base[arg->h]+2),
                 .cocsepdata = arg->cocsepdata,
                 .h48data = arg->h48data,
                 .selfsim = arg->selfsim,
@@ -340,19 +339,19 @@ gendata_h48k2(gendata_h48_arg_t *arg)
                 .shortcubes = &shortcubes
         };
 
-        i = 0;
+        i = ii = 0;
         for (kv = h48map_nextkvpair(&shortcubes, &i);
              i != shortcubes.capacity;
              kv = h48map_nextkvpair(&shortcubes, &i)
         ) {
-                /* TODO maybe over all sim? */
                 dfsarg.cube = invcoord_h48(kv.key, arg->crep, 11);
                 gendata_h48k2_dfs(&dfsarg);
+                if (++i % UINT64_C(1000000) == 0)
+                        LOG("Processed %" PRIu64 " short cubes\n", ii);
         }
 
         h48map_destroy(&shortcubes);
 
-        /* TODO: move info update to dfs? */
         memset(arg->info, 0, 5 * sizeof(arg->info[0]));
         arg->info[0] = base[arg->k];
         for (j = 0; j < H48_COORDMAX(arg->h); j++) {
@@ -367,29 +366,34 @@ gendata_h48k2_return_size:
 _static void
 gendata_h48k2_dfs(h48k2_dfs_arg_t *arg)
 {
-        uint8_t nmoves;
-        uint64_t val;
+        cube_t ccc;
+        bool toodeep, backtracked;
+        uint8_t nmoves, oldval, newval;
+        uint64_t mval;
         int64_t coord, fullcoord;
         h48k2_dfs_arg_t nextarg;
         uint8_t m;
 
-        fullcoord = coord_h48(arg->cube, arg->cocsepdata, 11);
-        coord = fullcoord >> (int64_t)(11 - arg->h);
-
-        val = h48map_value(arg->shortcubes, fullcoord);
-
-        if (arg->depth >= arg->base && arg->depth <= arg->base + 2)
+        ccc = arg->cube;
+        _foreach_h48sim(ccc, arg->cocsepdata, arg->selfsim, 11,
+                fullcoord = coord_h48(ccc, arg->cocsepdata, 11);
+                coord = fullcoord >> (int64_t)(11 - arg->h);
+                oldval = get_esep_pval(arg->h48data, coord, arg->k);
+                newval = arg->depth >= arg->base ? arg->depth - arg->base : 0;
                 set_esep_pval(
-                    arg->h48data, coord, arg->k, arg->depth - arg->base);
+                    arg->h48data, coord, arg->k, _min(oldval, newval));
+        )
 
-        if ((val < arg->shortdepth) ||
-            (arg->depth > arg->shortdepth && val != MAP_UNSET) ||
-            (arg->depth >= arg->maxdepth || arg->depth >= arg->base + 2))
+        fullcoord = coord_h48(arg->cube, arg->cocsepdata, 11); /* Necessary? */
+        mval = h48map_value(arg->shortcubes, fullcoord);
+        backtracked = mval <= arg->shortdepth && arg->depth != arg->shortdepth;
+        toodeep = arg->depth >= arg->maxdepth;
+        if (backtracked || toodeep)
                 return;
 
         /* TODO: avoid copy, change arg and undo changes after recursion */
         nextarg = *arg;
-        nextarg.depth = arg->depth + 1;
+        nextarg.depth++;
         nmoves = nextarg.depth - arg->shortdepth;
         for (m = 0; m < 18; m++) {
                 nextarg.moves[nmoves - 1] = m;
diff --git a/src/solvers/h48/map.h b/src/solvers/h48/map.h
index 82e5a2c..0e9f926 100644
--- a/src/solvers/h48/map.h
+++ b/src/solvers/h48/map.h
@@ -1,6 +1,7 @@
 #define MAP_UNSET             UINT64_C(0xFFFFFFFFFFFFFFFF)
 #define MAP_KEYMASK           UINT64_C(0xFFFFFFFFFF)
 #define MAP_KEYSHIFT          UINT64_C(40)
+#define MAP_UNSET_VAL         (MAP_UNSET >> MAP_KEYSHIFT)
 
 typedef struct {
         uint64_t n;
@@ -84,8 +85,8 @@ h48map_nextkvpair(h48map_t *map, uint64_t *p)
         kvpair_t kv;
         uint64_t pair;
 
-        kv.key = MAP_UNSET;
-        kv.val = MAP_UNSET;
+        kv.key = MAP_KEYMASK;
+        kv.val = MAP_UNSET_VAL;
 
         DBG_ASSERT(*p < map->capacity, kv,
             "Error looping over map: given index %" PRIu64 " is out of "
diff --git a/src/utils/math.h b/src/utils/math.h
index 87402e6..a361808 100644
--- a/src/utils/math.h
+++ b/src/utils/math.h
@@ -1,6 +1,7 @@
 #define _swap(x, y) do { x ^= y; y ^= x; x ^= y; } while (0)
 #define _min(x, y) ((x) < (y) ? (x) : (y))
 #define _max(x, y) ((x) > (y) ? (x) : (y))
+#define _div_round_up(n, d) (((n) + (d) - 1) / (d))
 
 _static int64_t factorial(int64_t);
 _static bool isperm(uint8_t *, int64_t);