Added TOOLARGS and simplified gendata tool(s)

22 files changed, 122 insertions, 294 deletions

diff --git a/.gitignore b/.gitignore
index fd603d5..e9a1741 100644
--- a/.gitignore
+++ b/.gitignore
@@ -10,6 +10,7 @@ test/*/runtest
 test/run
 test/run.DSYM
 run.DSYM
+run.core
 test/last.*
 tools/results
 .vscode
diff --git a/README.md b/README.md
index 09b5881..9ecd744 100644
--- a/README.md
+++ b/README.md
@@ -61,7 +61,7 @@ The results of the last test case run is saved in test/last.out (standard
 output, the results compared with the .out files) and test/last.err
 (standard error).
 
-Tests are always run in "debug mode": this means that optimizations are
+Tests are always run in debug mode: this means that optimizations are
 disabled and some extra logging is enabled.
 
 See the test folder and test/test.sh for details.
@@ -70,7 +70,7 @@ See the test folder and test/test.sh for details.
 
 In the tools folder there are some small programs that test various
 functionality of the H48 library. They work similarly to test, but they
-are not run in debug mode.
+are not run in debug mode by default.
 
 To run a tool you must select it with the environment variable `TOOL`.
 For example the command:
@@ -79,14 +79,26 @@ For example the command:
 TOOL=stats make tool
 ```
 
-Will run the stats_tables_h48 tool. Like for tests, the value of the
-`TOOL` variable can be any regular expression matching the name of the
-tool. Unlike tests, one and only one tool will be selected for each run.
+Will run the stats_tables_h48 tool.
+
+To pass some arguments to a tool, use the `TOOLARGS` variable:
+
+```
+TOOL=gendata TOOLARGS="h48 0;2;20" make tool
+```
+
+Like for tests, the value of the `TOOL` variable can be any regular
+expression matching the name of the tool. Unlike tests, one and
+only one tool will be selected for each run.  The content of the
+`TOOLARGS` variable is used directly as command line arguments for
+the chosen tool.
 
 Each tool run is automatically timed, so these tools can be used as
 benchmark.  The output as well as the time of the run are saved to a
 file in the tools/results folder.
 
+To build and run a tool in debug mode, use `make debugtool`.
+
 ## Running commands manually
 
 This project also includes a rudimentary shell that can be used to run
diff --git a/src/nissy.c b/src/nissy.c
index 6bc4aea..318cff1 100644
--- a/src/nissy.c
+++ b/src/nissy.c
@@ -11,7 +11,7 @@
 
 #include "nissy.h"
 
-STATIC int parse_h48_options(const char *, uint8_t *, uint8_t *, uint8_t *);
+int parse_h48_options(const char *, uint8_t *, uint8_t *, uint8_t *);
 STATIC int64_t write_result(cube_t, char [static 22]);
 
 /* TODO: add option to get DR, maybe C-only, E-only, eo... */
@@ -24,7 +24,7 @@ struct {
         GETCUBE_OPTIONS(NULL, NULL)
 };
 
-STATIC int
+int
 parse_h48_options(const char *buf, uint8_t *h, uint8_t *k, uint8_t *maxdepth)
 {
         bool h_valid, k_valid, maxdepth_valid;
diff --git a/tools/0002_gendata_h48h0k2/gendata_h48h0k2.c b/tools/0002_gendata_h48h0k2/gendata_h48h0k2.c
deleted file mode 100644
index 14f99ee..0000000
--- a/tools/0002_gendata_h48h0k2/gendata_h48h0k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 5473562,
-        [1] = 34776317,
-        [2] = 68566704,
-        [3] = 8750867,
-};
-
-void run(void) {
-        gendata_run("h48", "0;2;20", "tables/h48h0k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 0, k = 2");
-
-        return 0;
-}
diff --git a/tools/0004_gendata_h48h0k4/gendata_h48h0k4.c b/tools/0004_gendata_h48h0k4/gendata_h48h0k4.c
deleted file mode 100644
index ff34bb9..0000000
--- a/tools/0004_gendata_h48h0k4/gendata_h48h0k4.c
+++ /dev/null
@@ -1,29 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        [0] = 1,
-        [1] = 1,
-        [2] = 4,
-        [3] = 34,
-        [4] = 331,
-        [5] = 3612,
-        [6] = 41605,
-        [7] = 474128,
-        [8] = 4953846,
-        [9] = 34776317,
-        [10] = 68566704,
-        [11] = 8749194,
-        [12] = 1673,
-};
-
-void run(void) {
-        gendata_run("h48", "0;4;20", "tables/h48h0k4", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 0, k = 4");
-
-        return 0;
-}
diff --git a/tools/0012_gendata_h48h1k2/gendata_h48h1k2.c b/tools/0012_gendata_h48h1k2/gendata_h48h1k2.c
deleted file mode 100644
index 0ebdcaa..0000000
--- a/tools/0012_gendata_h48h1k2/gendata_h48h1k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "1;2;20", "tables/h48h1k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 1, k = 2");
-
-        return 0;
-}
diff --git a/tools/0022_gendata_h48h2k2/gendata_h48h2k2.c b/tools/0022_gendata_h48h2k2/gendata_h48h2k2.c
deleted file mode 100644
index f437e98..0000000
--- a/tools/0022_gendata_h48h2k2/gendata_h48h2k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "2;2;20", "tables/h48h2k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 2, k = 2");
-
-        return 0;
-}
diff --git a/tools/0032_gendata_h48h3k2/gendata_h48h3k2.c b/tools/0032_gendata_h48h3k2/gendata_h48h3k2.c
deleted file mode 100644
index 2e0eab5..0000000
--- a/tools/0032_gendata_h48h3k2/gendata_h48h3k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "3;2;20", "tables/h48h3k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 3, k = 2");
-
-        return 0;
-}
diff --git a/tools/0042_gendata_h48h4k2/gendata_h48h4k2.c b/tools/0042_gendata_h48h4k2/gendata_h48h4k2.c
deleted file mode 100644
index 868c360..0000000
--- a/tools/0042_gendata_h48h4k2/gendata_h48h4k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "4;2;20", "tables/h48h4k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 4, k = 2");
-
-        return 0;
-}
diff --git a/tools/0052_gendata_h48h5k2/gendata_h48h5k2.c b/tools/0052_gendata_h48h5k2/gendata_h48h5k2.c
deleted file mode 100644
index d292d49..0000000
--- a/tools/0052_gendata_h48h5k2/gendata_h48h5k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "5;2;20", "tables/h48h5k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 5, k = 2");
-
-        return 0;
-}
diff --git a/tools/0062_gendata_h48h6k2/gendata_h48h6k2.c b/tools/0062_gendata_h48h6k2/gendata_h48h6k2.c
deleted file mode 100644
index 910d514..0000000
--- a/tools/0062_gendata_h48h6k2/gendata_h48h6k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "6;2;20", "tables/h48h6k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 6, k = 2");
-
-        return 0;
-}
diff --git a/tools/0072_gendata_h48h7k2/gendata_h48h7k2.c b/tools/0072_gendata_h48h7k2/gendata_h48h7k2.c
deleted file mode 100644
index b803328..0000000
--- a/tools/0072_gendata_h48h7k2/gendata_h48h7k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "7;2;20", "tables/h48h7k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 7, k = 2");
-
-        return 0;
-}
diff --git a/tools/0082_gendata_h48h8k2/gendata_h48h8k2.c b/tools/0082_gendata_h48h8k2/gendata_h48h8k2.c
deleted file mode 100644
index 52c377a..0000000
--- a/tools/0082_gendata_h48h8k2/gendata_h48h8k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "8;2;20", "tables/h48h8k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 8, k = 2");
-
-        return 0;
-}
diff --git a/tools/0092_gendata_h48h9k2/gendata_h48h9k2.c b/tools/0092_gendata_h48h9k2/gendata_h48h9k2.c
deleted file mode 100644
index 5d3e34a..0000000
--- a/tools/0092_gendata_h48h9k2/gendata_h48h9k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "9;2;20", "tables/h48h9k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 9, k = 2");
-
-        return 0;
-}
diff --git a/tools/0102_gendata_h48h10k2/gendata_h48h10k2.c b/tools/0102_gendata_h48h10k2/gendata_h48h10k2.c
deleted file mode 100644
index 5e8fbb0..0000000
--- a/tools/0102_gendata_h48h10k2/gendata_h48h10k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "10;2;20", "tables/h48h10k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 10, k = 2");
-
-        return 0;
-}
diff --git a/tools/0112_gendata_h48h11k2/gendata_h48h11k2.c b/tools/0112_gendata_h48h11k2/gendata_h48h11k2.c
deleted file mode 100644
index 00c0747..0000000
--- a/tools/0112_gendata_h48h11k2/gendata_h48h11k2.c
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "../tool.h"
-
-uint64_t expected[21] = {
-        /* Base value is 8 */
-        [0] = 0, /* Unknown */
-        [1] = 0, /* Unknown */
-        [2] = 0, /* Unknown */
-        [3] = 0, /* Unknown */
-};
-
-void run(void) {
-        gendata_run("h48", "11;2;20", "tables/h48h11k2", expected);
-}
-
-int main(void) {
-        nissy_setlogger(log_stderr);
-
-        timerun(run, "benchmark gendata_h48 h = 11, k = 2");
-
-        return 0;
-}
diff --git a/tools/100_gendata/gendata.c b/tools/100_gendata/gendata.c
new file mode 100644
index 0000000..78f81ab
--- /dev/null
+++ b/tools/100_gendata/gendata.c
@@ -0,0 +1,80 @@
+#include "../tool.h"
+
+char *solver, *options;
+uint64_t *expected;
+
+uint64_t expected_h48[12][9][21] = {
+        [0] = {
+                [2] = {
+                        [0] = 5473562,
+                        [1] = 34776317,
+                        [2] = 68566704,
+                        [3] = 8750867,
+                },
+                [4] = {
+                        [0] = 1,
+                        [1] = 1,
+                        [2] = 4,
+                        [3] = 34,
+                        [4] = 331,
+                        [5] = 3612,
+                        [6] = 41605,
+                        [7] = 474128,
+                        [8] = 4953846,
+                        [9] = 34776317,
+                        [10] = 68566704,
+                        [11] = 8749194,
+                        [12] = 1673,
+                },
+        },
+};
+
+static void
+run(void) {
+        int64_t size;
+        char *buf, filename[1024];
+        
+        getfilename(solver, options, filename);
+        size = generatetable(solver, options, &buf);
+        switch (size) {
+        case -1:
+                return;
+        case -2:
+                goto gendata_run_finish;
+        default:
+                nissy_datainfo(buf, write_stdout);
+                printf("\n");
+                printf("Succesfully generated %" PRId64 " bytes. "
+                       "See above for details on the tables.\n", size);
+
+                writetable(buf, size, filename);
+                break;
+        }
+
+gendata_run_finish:
+        free(buf);
+}
+
+int main(int argc, char **argv) {
+        uint8_t h, k;
+        char description[256];
+
+        if (argc < 3) {
+                fprintf(stderr, "Error: not enough arguments."
+                    "A solver and its options must be given.\n");
+                return 1;
+        }
+
+        solver = argv[1];
+        options = argv[2];
+        parse_h48_options(options, &h, &k, NULL);
+        expected = expected_h48[h][k];
+        sprintf(description, "benchmark gendata_h48 h = %" PRIu8
+            ", k = %" PRIu8 "", h, k);
+
+        nissy_setlogger(log_stderr);
+
+        timerun(run, description);
+
+        return 0;
+}
diff --git a/tools/100_stats_tables_h48/stats_tables_h48.c b/tools/200_stats_tables_h48/stats_tables_h48.c
index adac8fa..adac8fa 100644
--- a/tools/100_stats_tables_h48/stats_tables_h48.c
+++ b/tools/200_stats_tables_h48/stats_tables_h48.c
diff --git a/tools/200_solve_small/solve_small.c b/tools/300_solve_small/solve_small.c
index 4d07728..4d07728 100644
--- a/tools/200_solve_small/solve_small.c
+++ b/tools/300_solve_small/solve_small.c
diff --git a/tools/nissy_extra.h b/tools/nissy_extra.h
new file mode 100644
index 0000000..17906d4
--- /dev/null
+++ b/tools/nissy_extra.h
@@ -0,0 +1,3 @@
+/* Intended only for tools */
+
+int parse_h48_options(const char *, uint8_t *, uint8_t *, uint8_t *);
diff --git a/tools/run_tool.sh b/tools/run_tool.sh
index 7e09684..2216a66 100755
--- a/tools/run_tool.sh
+++ b/tools/run_tool.sh
@@ -5,7 +5,7 @@ if [ -z "$TOOL" ]; then
         exit 1
 fi
 
-CC="$CC -D_POSIX_C_SOURCE=199309L"
+CC="$CC -D_POSIX_C_SOURCE=199309L" # For timer
 
 BIN="tools/run"
 d="$(date +'%Y-%m-%d-%H-%M-%S')"
@@ -16,7 +16,8 @@ for t in tools/*; do
         fi
         toolname="$(basename "$t" .c)"
         $CC -o $BIN "$t"/*.c "$CUBEOBJ" || exit 1;
-        $BIN | tee "tools/results/$toolname-$d.txt" "tools/results/last.out"
+        $BIN $TOOLARGS \
+                | tee "tools/results/$toolname-$d.txt" "tools/results/last.out"
         break
 done
 
diff --git a/tools/tool.h b/tools/tool.h
index 757657b..1540f22 100644
--- a/tools/tool.h
+++ b/tools/tool.h
@@ -6,14 +6,16 @@
 #include <stdlib.h>
 
 #include "../src/nissy.h"
+#include "nissy_extra.h"
 
 static void log_stderr(const char *, ...);
 static void log_stdout(const char *, ...);
 static double timerun(void (*)(void), const char *);
+static void getfilename(const char *, const char *, char *);
 static void writetable(const char *, int64_t, const char *);
 static int64_t generatetable(const char *, const char *, char **);
 static int getdata(const char *, const char *, char **, const char *);
-static void gendata_run(const char *, const char *, const char *, uint64_t[static 21]);
+static void gendata_run(const char *, const char *, uint64_t *);
 
 static void
 log_stderr(const char *str, ...)
@@ -70,6 +72,17 @@ timerun(void (*run)(void), const char *name)
 }
 
 static void
+getfilename(const char *solver, const char *options, char *filename)
+{
+        uint8_t h, k;
+
+        /* Only h48 supported for now */
+        parse_h48_options(options, &h, &k, NULL);
+
+        sprintf(filename, "tables/%sh%dk%d", solver, h, k);
+}
+
+static void
 writetable(const char *buf, int64_t size, const char *filename)
 {
         FILE *f;
@@ -155,13 +168,12 @@ static void
 gendata_run(
         const char *solver,
         const char *options,
-        const char *filename, /* TODO: remove filename, use solver name */
         uint64_t expected[static 21]
 ) {
         int64_t size;
-        char *buf;
+        char *buf, filename[1024];
 
-        
+        getfilename(solver, options, filename);
         size = generatetable(solver, options, &buf);
         switch (size) {
         case -1: