From 581865ee0c8b8aea872f053d804a41fb5f416b17 Mon Sep 17 00:00:00 2001
From: Sebastiano Tronto <sebastiano@tronto.net>
Date: Tue, 20 Jun 2023 23:01:09 +0200
Subject: Various shellcheck fixes (www.shellcheck.net)

---
 trash | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

(limited to 'trash')

diff --git a/trash b/trash
index 032d9fe..5ff5a27 100755
--- a/trash
+++ b/trash
@@ -4,25 +4,30 @@
 # current date.
 
 # Usage: trash [rm FILE(s)|ls|empty]
-# Pretty self-explanatory
 
 # ksh completion
 # set -A complete_trash_1 rm ls empty
 
 trashfolder=$XDG_DATA_HOME/mytrash
 
+usage() {
+	echo "Usage: trash [rm FILES... | ls | empty]"
+}
+
 if [ -z "$1" ]; then
-	echo "usage: trash [rm FILE(s)|ls|empty]"
-else
+	usage
+	exit 1
+fi
+
 case "$1" in
 	empty)
 		# little check
 		if [ -n "$trashfolder" ]; then
-			rm -rf $trashfolder/*
+			rm -rf "${trashfolder:?}"/*
 		fi
 		;;
 	ls)
-		ls $trashfolder
+		ls "$trashfolder"
 		;;
 	rm)
 		curdir=$(pwd | sed 's|.*/||')
@@ -33,7 +38,7 @@ case "$1" in
 		;;
 		
 	*)
-		echo "$1: not a valid command"
+		usage
+		exit 1
 		;;
 esac
-fi
-- 
cgit v1.3