From 7c934801f88c640970ad41b5ddd39f4e39609f28 Mon Sep 17 00:00:00 2001 From: Sebastiano Tronto Date: Tue, 27 May 2025 09:03:51 +0200 Subject: Removed VLA notation from function parameters. I found out that this gives undefined behavior when then size is 0. Better not to have it at all, it is confusing for other developers anyway. --- src/solvers/solutions.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/solvers/solutions.h') diff --git a/src/solvers/solutions.h b/src/solvers/solutions.h index 182ae18..cdb1fdb 100644 --- a/src/solvers/solutions.h +++ b/src/solvers/solutions.h @@ -1,11 +1,10 @@ STATIC void solution_moves_reset(solution_moves_t [static 1]); STATIC void solution_moves_transform(solution_moves_t [static 1], uint8_t); STATIC void solution_moves_reorient(solution_moves_t [static 1], uint8_t); -STATIC bool solution_list_init( - solution_list_t [static 1], size_t n, char [n]); +STATIC bool solution_list_init(solution_list_t [static 1], size_t, char *); STATIC bool solution_moves_equal( const solution_moves_t [static 1], const solution_moves_t [static 1]); -STATIC bool solution_moves_is_duplicate(size_t n, const solution_moves_t[n+1]); +STATIC bool solution_moves_is_duplicate(size_t, const solution_moves_t *); STATIC bool appendchar(solution_list_t [static 1], char); STATIC bool appendnormal( const solution_moves_t [static 1], solution_list_t [static 1]); @@ -50,7 +49,7 @@ solution_moves_reorient(solution_moves_t moves[static 1], uint8_t or) } STATIC bool -solution_list_init(solution_list_t sols[static 1], size_t n, char buf[n]) +solution_list_init(solution_list_t sols[static 1], size_t n, char *buf) { if (n == 0) return false; @@ -88,7 +87,7 @@ solution_moves_equal( } STATIC bool -solution_moves_is_duplicate(size_t n, const solution_moves_t s[n+1]) +solution_moves_is_duplicate(size_t n, const solution_moves_t *s) { size_t i; -- cgit v1.3