From 7c934801f88c640970ad41b5ddd39f4e39609f28 Mon Sep 17 00:00:00 2001
From: Sebastiano Tronto <sebastiano@tronto.net>
Date: Tue, 27 May 2025 09:03:51 +0200
Subject: Removed VLA notation from function parameters.

I found out that this gives undefined behavior when then size is 0.
Better not to have it at all, it is confusing for other developers anyway.
---
 src/solvers/coord/checkdata.h |  4 ++--
 src/solvers/coord/common.h    |  4 ++--
 src/solvers/coord/solve.h     | 19 +++++++++----------
 src/solvers/coord/utils.h     |  4 ++--
 4 files changed, 15 insertions(+), 16 deletions(-)

(limited to 'src/solvers/coord')

diff --git a/src/solvers/coord/checkdata.h b/src/solvers/coord/checkdata.h
index 81394c7..791761f 100644
--- a/src/solvers/coord/checkdata.h
+++ b/src/solvers/coord/checkdata.h
@@ -1,11 +1,11 @@
 STATIC long long checkdata_coord(
-    const char *, unsigned long long n, const unsigned char [n]);
+    const char *, unsigned long long, const unsigned char *);
 
 STATIC long long
 checkdata_coord(
 	const char *solver,
 	unsigned long long data_size,
-	const unsigned char data[data_size]
+	const unsigned char *data
 )
 {
 	coord_t *coord;
diff --git a/src/solvers/coord/common.h b/src/solvers/coord/common.h
index 8fd405c..c512b33 100644
--- a/src/solvers/coord/common.h
+++ b/src/solvers/coord/common.h
@@ -9,7 +9,7 @@ STATIC size_t coord_gendata_generic(const coord_t [static 1], unsigned char *);
 STATIC void append_coord_name(const coord_t [static 1], char *);
 STATIC bool solution_lastqt_cw(const solution_moves_t [static 1]);
 STATIC bool coord_can_switch(const coord_t [static 1], const unsigned char *,
-    size_t n, const uint8_t [n]);
+    size_t, const uint8_t *);
 
 STATIC uint64_t
 coord_coord_generic(
@@ -164,7 +164,7 @@ coord_can_switch(
 	const coord_t coord[static 1],
 	const unsigned char *data,
 	size_t n,
-	const uint8_t moves[n]
+	const uint8_t *moves
 )
 {
 	/*
diff --git a/src/solvers/coord/solve.h b/src/solvers/coord/solve.h
index 018aa90..a2f89db 100644
--- a/src/solvers/coord/solve.h
+++ b/src/solvers/coord/solve.h
@@ -13,13 +13,12 @@ typedef struct {
 } dfsarg_solve_coord_t;
 
 STATIC int64_t solve_coord(oriented_cube_t, coord_t [static 1], uint8_t,
-    uint8_t, uint8_t, uint8_t, uint64_t, uint8_t, uint8_t, uint64_t n,
-    const unsigned char [n], size_t m, char [m], int (*)(void *), void *);
+    uint8_t, uint8_t, uint8_t, uint64_t, uint8_t, uint8_t, uint64_t,
+    const unsigned char *, size_t, char *, int (*)(void *), void *);
 STATIC long long solve_coord_dispatch(oriented_cube_t, const char *, unsigned,
-    unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long n,
-    const unsigned char [n], unsigned m, char [m],
-    long long [static NISSY_SIZE_SOLVE_STATS],
-    int (*)(void *), void *);
+    unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long,
+    const unsigned char *, unsigned, char *,
+    long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *);
 STATIC bool coord_solution_admissible(const dfsarg_solve_coord_t [static 1]);
 STATIC bool solve_coord_dfs_stop(const dfsarg_solve_coord_t [static 1]);
 STATIC bool coord_continue_onnormal(const dfsarg_solve_coord_t [static 1]);
@@ -210,9 +209,9 @@ solve_coord_dispatch(
 	unsigned optimal,
 	unsigned threads,
 	unsigned long long data_size,
-	const unsigned char data[data_size],
+	const unsigned char *data,
 	unsigned solutions_size,
-	char sols[solutions_size],
+	char *sols,
 	long long stats[static NISSY_SIZE_SOLVE_STATS],
 	int (*poll_status)(void *),
 	void *poll_status_data
@@ -251,9 +250,9 @@ solve_coord(
 	uint8_t optimal,
 	uint8_t threads,
 	uint64_t data_size,
-	const unsigned char data[data_size],
+	const unsigned char *data,
 	size_t solutions_size,
-	char sols[solutions_size],
+	char *sols,
 	int (*poll_status)(void *),
 	void *poll_status_data
 )
diff --git a/src/solvers/coord/utils.h b/src/solvers/coord/utils.h
index 6066049..5b8f538 100644
--- a/src/solvers/coord/utils.h
+++ b/src/solvers/coord/utils.h
@@ -1,10 +1,10 @@
-STATIC coord_t *parse_coord(size_t n, const char [n]);
+STATIC coord_t *parse_coord(size_t, const char *);
 STATIC uint8_t parse_axis(const char [static 2]);
 STATIC void parse_coord_and_axis(const char *, coord_t **, uint8_t *);
 STATIC long long dataid_coord(const char *, char [static NISSY_SIZE_DATAID]);
 
 STATIC coord_t *
-parse_coord(size_t n, const char coord[n])
+parse_coord(size_t n, const char *coord)
 {
 	int i;
 
-- 
cgit v1.3