From 7c934801f88c640970ad41b5ddd39f4e39609f28 Mon Sep 17 00:00:00 2001 From: Sebastiano Tronto Date: Tue, 27 May 2025 09:03:51 +0200 Subject: Removed VLA notation from function parameters. I found out that this gives undefined behavior when then size is 0. Better not to have it at all, it is confusing for other developers anyway. --- src/solvers/coord/solve.h | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) (limited to 'src/solvers/coord/solve.h') diff --git a/src/solvers/coord/solve.h b/src/solvers/coord/solve.h index 018aa90..a2f89db 100644 --- a/src/solvers/coord/solve.h +++ b/src/solvers/coord/solve.h @@ -13,13 +13,12 @@ typedef struct { } dfsarg_solve_coord_t; STATIC int64_t solve_coord(oriented_cube_t, coord_t [static 1], uint8_t, - uint8_t, uint8_t, uint8_t, uint64_t, uint8_t, uint8_t, uint64_t n, - const unsigned char [n], size_t m, char [m], int (*)(void *), void *); + uint8_t, uint8_t, uint8_t, uint64_t, uint8_t, uint8_t, uint64_t, + const unsigned char *, size_t, char *, int (*)(void *), void *); STATIC long long solve_coord_dispatch(oriented_cube_t, const char *, unsigned, - unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long n, - const unsigned char [n], unsigned m, char [m], - long long [static NISSY_SIZE_SOLVE_STATS], - int (*)(void *), void *); + unsigned, unsigned, unsigned, unsigned, unsigned, unsigned long long, + const unsigned char *, unsigned, char *, + long long [static NISSY_SIZE_SOLVE_STATS], int (*)(void *), void *); STATIC bool coord_solution_admissible(const dfsarg_solve_coord_t [static 1]); STATIC bool solve_coord_dfs_stop(const dfsarg_solve_coord_t [static 1]); STATIC bool coord_continue_onnormal(const dfsarg_solve_coord_t [static 1]); @@ -210,9 +209,9 @@ solve_coord_dispatch( unsigned optimal, unsigned threads, unsigned long long data_size, - const unsigned char data[data_size], + const unsigned char *data, unsigned solutions_size, - char sols[solutions_size], + char *sols, long long stats[static NISSY_SIZE_SOLVE_STATS], int (*poll_status)(void *), void *poll_status_data @@ -251,9 +250,9 @@ solve_coord( uint8_t optimal, uint8_t threads, uint64_t data_size, - const unsigned char data[data_size], + const unsigned char *data, size_t solutions_size, - char sols[solutions_size], + char *sols, int (*poll_status)(void *), void *poll_status_data ) -- cgit v1.3